Skip to content

ci: Bump docker/login-action from 3 to 4 - #96

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/docker/login-action-4
Closed

ci: Bump docker/login-action from 3 to 4#96
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/docker/login-action-4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 15, 2026

Copy link
Copy Markdown
Contributor

Bumps docker/login-action from 3 to 4.

Release notes

Sourced from docker/login-action's releases.

v4.0.0

Full Changelog: docker/login-action@v3.7.0...v4.0.0

v3.7.0

Full Changelog: docker/login-action@v3.6.0...v3.7.0

v3.6.0

Full Changelog: docker/login-action@v3.5.0...v3.6.0

v3.5.0

Full Changelog: docker/login-action@v3.4.0...v3.5.0

v3.4.0

Full Changelog: docker/login-action@v3.3.0...v3.4.0

... (truncated)

Commits
  • 650006c Merge pull request #960 from docker/dependabot/npm_and_yarn/aws-sdk-dependenc...
  • 99df1a3 chore: update generated content
  • 3ab375f build(deps): bump the aws-sdk-dependencies group across 1 directory with 2 up...
  • 39d8580 Merge pull request #970 from docker/dependabot/npm_and_yarn/docker/actions-to...
  • 4eefcd3 chore: update generated content
  • 56d092c build(deps): bump @​docker/actions-toolkit from 0.86.0 to 0.90.0
  • e2e31ca Merge pull request #976 from docker/dependabot/npm_and_yarn/actions/core-3.0.1
  • 0bced94 chore: update generated content
  • 3e75a0f build(deps): bump @​actions/core from 3.0.0 to 3.0.1
  • 365bebd Merge pull request #984 from docker/dependabot/github_actions/aws-actions/con...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [docker/login-action](https://github.com/docker/login-action) from 3 to 4.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v3...v4)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jun 15, 2026
bilby91 added a commit that referenced this pull request Sep 1, 2026
* deps: bump the pending Go module updates

Folds the six open dependabot module bumps into one change, taking the
latest release of each rather than the version each PR was cut against:

- compose-spec/compose-go/v2 2.11.0 -> 2.14.0 (#112)
- google/go-containerregistry 0.21.7 -> 0.22.0 (#113 asked for 0.21.9)
- moby/moby/api 1.54.2 -> 1.55.0, moby/moby/client 0.4.1 -> 0.5.1 (#100)
- golang.org/x/term 0.43.0 -> 0.45.0 (#110)
- google.golang.org/protobuf 1.36.11 -> 1.36.12 (#114)

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* ci: bump the pending GitHub Actions updates

All four are majors whose breaking changes are the Node 24 runtime
default and an ESM migration; the workflows pass no inputs that the
majors removed, and no workflow uses pull_request_target or
workflow_run, which is the trigger pair actions/checkout v7 newly
refuses to check out fork PRs for.

- actions/checkout v6 (ci.yml) and v4 (devcontainer-*.yml) -> v7 (#99)
- actions/setup-go v6 -> v7 (#111)
- docker/login-action v3 -> v4 (#96)
- docker/setup-buildx-action v3 -> v4 (#95)

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(compose): refuse the compose lifecycle hooks on the native path

compose-go 2.14 adds ServiceConfig.PreStart, so `pre_start` — which
2.11 rejected at schema validation — now loads cleanly. The native
orchestrator creates the service container directly and has no
ephemeral init-container step, so it dropped the hook silently; and
because the hooks are part of the ServiceConfig that ConfigHash
covers, editing a hook that never ran read as a config change and
stopped and removed the running container, destroying its writable
layer.

Refused in Plan.Validate via the existing §2.2 unsupported-field
mechanism, before any infrastructure side effect. stripForHash drops
the three fields as well: the refusal already makes them unreachable
there, but a recreation is unrecoverable, so no field the orchestrator
does not execute should be able to trigger one if the refusal moves or
a caller reaches ConfigHash directly.

post_start and pre_stop parsed cleanly under 2.11 and had the same
defect, so all three are refused rather than just the one the bump
introduced. The shell-out backend is untouched — it delegates to
`docker compose`, which implements the hooks.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(compose): refuse unsupported fields before building anything

The §2.2 refusal ran only inside Orchestrator.Up, which the engine
reaches after prepareComposeServiceImage, layerFeatures and
buildComposeSidecarImages. A native project using a refused field
therefore paid for the primary image and every sidecar build, and
left those images tagged, before being told the engine will not run
it.

Plan.Validate already documents itself as side-effect-free and safe
to call before any backend interaction, so the fix is to call it
where that matters: straight after compose.Load. The orchestrator's
own validation stays as the authoritative one.

Native backend only. The shell-out path hands the project to
`docker compose`, which implements hooks and other fields the native
orchestrator refuses, so validating there would reject projects that
work today.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: bilby91 <2201079+bilby91@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@bilby91

bilby91 commented Sep 1, 2026

Copy link
Copy Markdown
Member

Superseded by #129, which folded every open dependency bump into one change. This PR was cut against a main that still had the Podman backend, the Apple Containers backend and the per-backend capability gating, so it needed a rebase and its green CI was measuring a tree that no longer exists.

docker/login-action is on v4 as of #129.

@dependabot close

@bilby91 bilby91 closed this Sep 1, 2026
@dependabot @github

dependabot Bot commented on behalf of github Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/github_actions/docker/login-action-4 branch September 1, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant